fix(azure): check account_key before DefaultAzureCredential#51999
Merged
potiuk merged 1 commit intoapache:mainfrom Jun 21, 2025
Merged
fix(azure): check account_key before DefaultAzureCredential#51999potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
- Check account_key in connection extra before falling back to DefaultAzureCredential - Ensure proper authentication precedence for WasbHook and WasbAsyncHook - Add test case for account_key authentication - Update documentation to clarify account_key authentication method and priority - Update hook docstring and UI placeholders to reflect account_key support - Fixes apache#51944
potiuk
approved these changes
Jun 21, 2025
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Azure Blob Storage authentication to prioritize account_key over DefaultAzureCredential
Problem Description
The
WasbHookandWasbAsyncHookhad an authentication priority issue where theaccount_keyfield in connection extras was being skipped when no password was provided. The hooks would directly fall back toDefaultAzureCredentialwithout checking foraccount_key, causing authentication failures for users who configured their connections with account keys in the extra fields.Solution
WasbHook.get_conn()andWasbAsyncHook.get_async_conn()to check foraccount_keyin connection extras before falling back toDefaultAzureCredentialaccount_keyauthentication methodTests
test_account_key_connectiontest case to verify account_key authentication works correctlyChanges
Verification
This fix ensures that users can successfully authenticate using
account_keyin connection extras as documented in the hook's class docstring: "These parameters have to be passed in Airflow Data Base: account_name and account_key."closes: #51944
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.